Address edits by offset value #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_changed This keeps the coding style a bit more consistent
Rename append_to_travel_history to append_history
brkzlr
requested changes
Sep 19, 2024
| dialog = InputDialogForm(self, item_list=[("Offset addresses by:",'')]) | ||
| if dialog.exec(): | ||
| offset_value = dialog.get_values() | ||
| offset_int = int(offset_value, 16) |
There was a problem hiding this comment.
What if the user does not input a valid hex number?
| print(offset_int) | ||
| for row in self.treeWidget_AddressTable.selectedItems(): | ||
| desc, address_expr, value_type = self.read_address_table_entries(row) | ||
| address = row.text(ADDR_COL).strip("P->") |
There was a problem hiding this comment.
You're stripping P-> but that's grabbing the resolved address from the pointer chain.
Unless you modify the chain and add the value to the last offset directly, it will just break again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added small feature to allow changing selected addresses by specified offset value. Using either the Edit popup menu option or the Shift+Return shortcut, a hex value can be entered (positive or negative) and will then modify the addresses of all selected records by that value.