Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify linker invocations + argument parsing + struct LinkerScript #30

Merged
merged 21 commits into from
Apr 10, 2021
Merged

Simplify linker invocations + argument parsing + struct LinkerScript #30

merged 21 commits into from
Apr 10, 2021

Conversation

Urhengulas
Copy link
Member

No description provided.

@Urhengulas Urhengulas changed the title Simplify linker invocations Simplify linker invocations + argument parsing Apr 1, 2021
@Urhengulas Urhengulas changed the title Simplify linker invocations + argument parsing Simplify linker invocations + argument parsing + struct LinkerScript Apr 1, 2021
@Urhengulas Urhengulas requested a review from Lotterleben April 5, 2021 14:13
Lotterleben
Lotterleben reviewed Apr 6, 2021
View reviewed changes
Copy link

@Lotterleben Lotterleben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general impression: looks much more orderly! I like :)

src/linking.rs Outdated Show resolved Hide resolved
src/linking.rs Outdated Show resolved Hide resolved
src/linking.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
japaric
japaric reviewed Apr 9, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great module the comment about process::exit

src/linking.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@japaric
Copy link
Member

japaric commented Apr 9, 2021

bors d+
you should be able to send this PR to bors (I think we have bors here). bors command reference

@bors
Copy link
Contributor

bors bot commented Apr 9, 2021

✌️ Urhengulas can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Urhengulas
Copy link
Member Author

bors r+

@Urhengulas
Copy link
Member Author

bors d+
you should be able to send this PR to bors (I think we have bors here). bors command reference

Thanks for the d+ :) I should be able to r+ it anyways.

@bors
Copy link
Contributor

bors bot commented Apr 10, 2021

Build succeeded:

@bors bors bot merged commit 14a842c into main Apr 10, 2021
@bors bors bot deleted the simplify branch April 10, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric left review comments

@Lotterleben Lotterleben Lotterleben left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Urhengulas @japaric @Lotterleben