Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.16] Complete Consumer verticle stop promise only after closing dependencies #4183

Open
wants to merge 1 commit into
base: release-1.16
Choose a base branch
from
Open

[release-1.16] Complete Consumer verticle stop promise only after closing dependencies #4183

wants to merge 1 commit into from

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #4181

Complete Consumer verticle stop promise only after closing dependencies

@pierDipi @knative-prow-robot
Complete Consumer verticle stop promise only after closing dependencies
d5568c0 
Completing the stop promise before the dependencies (dispatcher, client,
etc) before will cause the WebClient to be closed.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow-robot knative-prow-robot mentioned this pull request Dec 12, 2024
Merged
@knative-prow knative-prow bot requested review from aliok and creydr December 12, 2024 22:20
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2024
matzew
matzew approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@pierDipi
Copy link
Member

/retest-required

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 18, 2024 •
edited
Loading

@knative-prow-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
channel-integration-tests-sasl-plain_eventing-kafka-broker_release-1.16 d5568c0 link true /test channel-integration-tests-sasl-plain
upgrade-tests_eventing-kafka-broker_release-1.16 d5568c0 link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@creydr creydr Awaiting requested review from creydr

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-prow-robot @pierDipi @matzew