-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add b3 propagator for tracing #1546
add b3 propagator for tracing #1546
Conversation
Welcome @snowwolf007cn! It looks like this is your first PR to knative-sandbox/eventing-kafka-broker 🎉 |
Hi @snowwolf007cn. Thanks for your PR. I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @snowwolf007cn !
I left some comments inline and I'd also rename everywhere headsFormat
to headersFormat
for better clarity.
data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/tracing/TracingConfig.java
Outdated
Show resolved
Hide resolved
...ane/core/src/test/java/dev/knative/eventing/kafka/broker/core/tracing/TracingConfigTest.java
Outdated
Show resolved
Hide resolved
…r/core/tracing/TracingConfig.java Co-authored-by: Pierangelo Di Pilato <[email protected]>
@snowwolf007cn there is a problem with the CLA, please take a look: https://github.com/knative-sandbox/eventing-kafka-broker/pull/1546/checks?check_run_id=4331388121 |
I think you've rescanned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Some more renaming.
...ane/core/src/test/java/dev/knative/eventing/kafka/broker/core/tracing/TracingConfigTest.java
Outdated
Show resolved
Hide resolved
...ane/core/src/test/java/dev/knative/eventing/kafka/broker/core/tracing/TracingConfigTest.java
Outdated
Show resolved
Hide resolved
...ane/core/src/test/java/dev/knative/eventing/kafka/broker/core/tracing/TracingConfigTest.java
Outdated
Show resolved
Hide resolved
data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/tracing/TracingConfig.java
Outdated
Show resolved
Hide resolved
data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/tracing/TracingConfig.java
Outdated
Show resolved
Hide resolved
data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/tracing/TracingConfig.java
Outdated
Show resolved
Hide resolved
…r/core/tracing/TracingConfigTest.java Co-authored-by: Pierangelo Di Pilato <[email protected]>
…r/core/tracing/TracingConfigTest.java Co-authored-by: Pierangelo Di Pilato <[email protected]>
…r/core/tracing/TracingConfigTest.java Co-authored-by: Pierangelo Di Pilato <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1546 +/- ##
============================================
- Coverage 75.33% 75.33% -0.01%
- Complexity 588 593 +5
============================================
Files 107 107
Lines 4128 4152 +24
Branches 165 170 +5
============================================
+ Hits 3110 3128 +18
- Misses 762 765 +3
- Partials 256 259 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@snowwolf007cn the failure wants you to regenerate the file with third-party licenses by running this command:
|
inside the |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, snowwolf007cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind enhancement |
Hello everyone, could someone please show me how to replace knative propagator to use B3 instead if W3C by default |
Fixes #725
Proposed Changes
Release Note
Docs