Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add b3 propagator for tracing #1546

Merged
merged 11 commits into from
Nov 26, 2021

Conversation

snowwolf007cn
Copy link
Contributor

Fixes #725

Proposed Changes

  • add heads-format config entry in config-tracing, default is 'w3c'
  • when the backend is 'zipkin', 'b3-multi-header' and 'b3-single-header' is supported to propagate with b3 headers
  • config propagator to use 'w3c' or 'b3'

Release Note

🎁 you can now config which header format(b3 multi header, b3 single header, and w3c trace-context) to be used while using Zipkin backend

Docs

@google-cla google-cla bot added the cla: no Indicates the PR's author has not signed the CLA. label Nov 26, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2021
@knative-prow-robot
Copy link
Contributor

Welcome @snowwolf007cn! It looks like this is your first PR to knative-sandbox/eventing-kafka-broker 🎉

@knative-prow-robot
Copy link
Contributor

Hi @snowwolf007cn. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @snowwolf007cn !

I left some comments inline and I'd also rename everywhere headsFormat to headersFormat for better clarity.

…r/core/tracing/TracingConfig.java

Co-authored-by: Pierangelo Di Pilato <[email protected]>
@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Nov 26, 2021
@pierDipi
Copy link
Member

@snowwolf007cn
Copy link
Contributor Author

@snowwolf007cn there is a problem with the CLA, please take a look: https://github.com/knative-sandbox/eventing-kafka-broker/pull/1546/checks?check_run_id=4331388121

I think you've rescanned.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Some more renaming.

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2021
snowwolf007cn and others added 3 commits November 26, 2021 17:00
…r/core/tracing/TracingConfigTest.java

Co-authored-by: Pierangelo Di Pilato <[email protected]>
…r/core/tracing/TracingConfigTest.java

Co-authored-by: Pierangelo Di Pilato <[email protected]>
…r/core/tracing/TracingConfigTest.java

Co-authored-by: Pierangelo Di Pilato <[email protected]>
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #1546 (c736ef7) into main (1ae3943) will decrease coverage by 0.00%.
The diff coverage is 80.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1546      +/-   ##
============================================
- Coverage     75.33%   75.33%   -0.01%     
- Complexity      588      593       +5     
============================================
  Files           107      107              
  Lines          4128     4152      +24     
  Branches        165      170       +5     
============================================
+ Hits           3110     3128      +18     
- Misses          762      765       +3     
- Partials        256      259       +3     
Flag Coverage Δ
java-unittests 82.01% <80.64%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nting/kafka/broker/core/tracing/TracingConfig.java 73.72% <80.64%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae3943...c736ef7. Read the comment docs.

@pierDipi
Copy link
Member

@snowwolf007cn the failure wants you to regenerate the file with third-party licenses by running this command:

./mvnw -Dlicense.outputDirectory=. license:aggregate-add-third-party

@pierDipi
Copy link
Member

inside the data-plane directory.

@snowwolf007cn
Copy link
Contributor Author

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, snowwolf007cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2021
@knative-prow-robot knative-prow-robot merged commit b1a1878 into knative-extensions:main Nov 26, 2021
@pierDipi
Copy link
Member

/kind enhancement

@hassanbenhzaine
Copy link

Hello everyone, could someone please show me how to replace knative propagator to use B3 instead if W3C by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support B3 headers in OTEL propagation
4 participants