Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support tracing B3 headers #1076

Closed

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani [email protected]

Fixes #725

Proposed Changes

  • 🎁 Support configuration of tracing context injectors.
  • 🎁 Support context extraction both from b3 and w3c headers

Release Note

:gift: Support context extraction both from w3c and b3 headers transparently
:gift: Support configuration of tracing context injectors. Now you can specify in the config-tracing ConfigMap whether you want to emit tracing headers in w3c format, b3 format or both 

Docs

Perhaps we need that?

Signed-off-by: Francesco Guardiani <[email protected]>
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added area/data-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 2, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2021
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #1076 (3a943d1) into main (e6ca0b4) will decrease coverage by 4.16%.
The diff coverage is 81.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1076      +/-   ##
============================================
- Coverage     79.91%   75.75%   -4.17%     
- Complexity      462      469       +7     
============================================
  Files            58       87      +29     
  Lines          1653     3023    +1370     
  Branches        138      141       +3     
============================================
+ Hits           1321     2290     +969     
- Misses          259      565     +306     
- Partials         73      168      +95     
Flag Coverage Δ
java-unittests 80.07% <81.08%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nting/kafka/broker/core/tracing/TracingConfig.java 74.10% <81.08%> (+0.70%) ⬆️
control-plane/pkg/security/secret.go 97.89% <0.00%> (ø)
control-plane/pkg/reconciler/kafka/topic.go 87.50% <0.00%> (ø)
control-plane/pkg/core/config/utils.go 75.00% <0.00%> (ø)
control-plane/pkg/reconciler/base/reconciler.go 72.72% <0.00%> (ø)
...ane/pkg/apis/eventing/v1alpha1/kafka_sink_types.go 75.00% <0.00%> (ø)
...lane/pkg/reconciler/base/receiver_condition_set.go 0.00% <0.00%> (ø)
control-plane/pkg/reconciler/broker/controller.go 76.38% <0.00%> (ø)
.../pkg/apis/eventing/v1alpha1/kafka_sink_defaults.go 100.00% <0.00%> (ø)
control-plane/pkg/security/config.go 53.33% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ca0b4...3a943d1. Read the comment docs.

@knative-prow-robot
Copy link
Contributor

@slinkydeveloper: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-sandbox-eventing-kafka-broker-build-tests 3a943d1 link /test pull-knative-sandbox-eventing-kafka-broker-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2021
@pierDipi
Copy link
Member

pierDipi commented Oct 1, 2021

/remove-lifecycle stale
/lifecycle frozen

@knative-prow-robot
Copy link
Contributor

@pierDipi: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/remove-lifecycle stale
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2021
@matzew
Copy link
Contributor

matzew commented Oct 4, 2021

/close

see #1278

@knative-prow-robot
Copy link
Contributor

@matzew: Closed this PR.

In response to this:

/close

see #1278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi pushed a commit to Cali0707/eventing-kafka-broker that referenced this pull request May 7, 2024
)

go mod vendor
make generate-release

Signed-off-by: Calum Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support B3 headers in OTEL propagation
4 participants