Papermc arclight #1

Fellsoul · 2024-03-07T07:47:49Z

把papermc和arclight的下载器做好了，在readme里改了日志。本地都调试过了，papermc支持所有有的版本，arclight多加了一个判断并且告诉用户什么版本已经expired不能再选了（虽然强硬要选也会被驳回吧

zyxkad · 2024-03-07T22:23:54Z

arclight_installer.go

+		}
+		return "", &VersionNotFoundErr{target}
+	}
+DownloadPart:


Label 用全大写字母+下划线，另外，能不用goto就别用

zyxkad · 2024-03-07T22:24:45Z

arclight_installer.go

+}
+
+func (r *ArclightInstaller) Runbuilder(buildJar string, ExactDownloadName string, path string) (installed string, err error) {
+	currentDir, err := os.Getwd()


Getwd 和 . 一个意思，这里没有必要再获取一遍

zyxkad · 2024-03-07T22:26:24Z

arclight_installer.go

+	if err != nil {
+		return
+	}
+	serverDirectory := filepath.Join(currentDir, "server-"+ExactDownloadName[0:len(ExactDownloadName)-4])


不要出现 len(ExactDownloadName)-4 这样需要联系方法外上下文的迷之操作

zyxkad · 2024-03-07T22:27:32Z

cli/usage.go

@@ -1,31 +1 @@
 package main
-


usage 太长，所以单放一个文件

zyxkad · 2024-03-07T22:28:29Z

httpclient.go

@@ -193,3 +193,40 @@ func (c *HTTPClient) PostForm(url string, form url.Values) (res *http.Response,
 	return c.Post(url, "application/x-www-form-urlencoded",
 		strings.NewReader(formStr))
 }
+
+func (c *HTTPClient) DownloadDirect(url string, ExactDownloadeName string, cb DlCallback) (installed string, err error) {
+	resp, err := http.Head(url)


这个用不到的操作是做甚的

zyxkad · 2024-03-07T22:28:56Z

httpclient.go

+	}
+	defer resp.Body.Close()
+	filename := filepath.Base(url)
+	flags := os.O_CREATE | os.O_WRONLY


flags 不用单列出一个变量，因为下面用不到，也不会被修改

zyxkad · 2024-03-07T22:29:17Z

httpclient.go

+	defer resp.Body.Close()
+	filename := filepath.Base(url)
+	flags := os.O_CREATE | os.O_WRONLY
+	f, err := os.OpenFile(filename, flags, 0666)


0666不是安全的权限，改成0644

zyxkad · 2024-03-07T22:29:42Z

httpclient.go

+	}
+	defer f.Close()
+
+	buf := make([]byte, 16*1024)


如果是现make buffer就别make了，直接用io.Copy

zyxkad · 2024-03-07T22:30:32Z

papermc_installer.go

+}
+
+func (r *PapermcInstaller) GetInstallerVersions() (data []string, err error) {
+	link := "https://api.papermc.io/v2/projects/paper"


常量用 const, 另外你上面定义了 paperURL 这里为什么还要 hardcode

我的错。我不明白“url”的因素。我认为其他文件中引用了它们

zyxkad · 2024-03-07T22:31:12Z

papermc_installer.go

+	if err = cmd.Run(); err != nil {
+		return
+	}
+	installed = buildJar + "\n"


installer 不换行啊，这是通知可能存在的父程序文件下载到哪里去了

正确的。我没有意识到变量用作地址，只考虑输出

zyxkad · 2024-03-07T22:43:05Z

arclight_installer.go

+	if err != nil {
+		return data, err
+	}
+	for i := 0; i < len(releases); i += 1 {


i += 1 就是 i++

Suggested change

for i := 0; i < len(releases); i += 1 {

for _, release := range releases {

zyxkad · 2024-03-07T22:44:14Z

arclight_installer.go

+		if err != nil {
+			return data, err
+		}
+		if year < 2024 || (year == 2024 && month < 2) {


year < 2024 是个什么操作????

判断是否过期，因为在2024.2月以前的所有构建都失效了，而且想不到比这样判断更好的方法了，就直接这样硬编码了

zyxkad · 2024-03-07T22:46:34Z

README.MD

@@ -80,6 +82,12 @@ minecraft_installer -name minecraft_server -version 1.16.5 -server forge
 minecraft_installer -name minecraft_server -version 1.19.2 -server fabric -path server
 ```

+```sh
+# Install papermc 1.14.4 server into {PATH}/server-1.14.4-{BUILDNUM}/{PAPERMC-INSTALLED-NAME}.jar


格式错了，应该下载到提供的 name 参数那里去

好的我run所有文件再调试一下，之前不是太清楚命令行操作

zyxkad · 2024-03-07T23:01:07Z

arclight_installer.go

+		}
+		loger.Info("not find the suitable builder, the version should be included in the following list:")
+		for i := 0; i < len(allVersions); i += 1 {
+			if data[allVersions[i]].IsExpired == true {


为什么我还是能遇到 == true 这种操作 😓

Suggested change

if data[allVersions[i]].IsExpired == true {

if data[allVersions[i]].IsExpired {

zyxkad · 2024-03-07T23:02:14Z

arclight_installer.go

+	return data, err
+}
+
+func (r *ArclightInstaller) GetOnlyVersions(data map[string]ArclightRelease) (versions []string) {


GetOnlyVersions 是干嘛的，如果是辅助函数那就不要放到 Installer 的方法里

zyxkad · 2024-03-07T23:02:26Z

arclight_installer.go

+}
+
+func (r *ArclightInstaller) GetOnlyVersions(data map[string]ArclightRelease) (versions []string) {
+	for k := range data {


Suggested change

for k := range data {

for k, _ := range data {

zyxkad · 2024-03-07T23:03:30Z

arclight_installer.go

+			}
+			goto DownloadPart
+		}
+		for i := 0; i < len(allVersions); i += 1 {


Suggested change

for i := 0; i < len(allVersions); i += 1 {

for _, version := range allVersions {

或者直接

Suggested change

for i := 0; i < len(allVersions); i += 1 {

for version, _ := range data {

zyxkad · 2024-03-07T23:04:26Z

arclight_installer.go

+	if err != nil {
+		return data, err
+	}
+	for i := 0; i < len(releases); i += 1 {


Suggested change

for i := 0; i < len(releases); i += 1 {

for _, release := range releases {

zyxkad · 2024-03-07T23:04:32Z

arclight_installer.go

+func (r *ArclightInstaller) GetInstallerVersions() (map[string]ArclightRelease, error) {
+	data := make(map[string]ArclightRelease)
+	link := "https://api.github.com/repos/IzzelAliz/Arclight/releases"
+	var releases []ArclightRelease


Suggested change

var releases []ArclightRelease

var releases []*ArclightRelease

zyxkad · 2024-03-07T23:06:08Z

arclight_installer.go

+DownloadPart:
+	ExactDownloadeName := data[loader].Assets[0].AssetsName
+	ArclightInstallerUrl := data[loader].Assets[0].DownloadUrl
+	if data[loader].IsExpired == true {


你不能假设loader存在于data里

Suggested change

if data[loader].IsExpired == true {

if version, ok := data[loader]; ok && version.IsExpired {

zyxkad · 2024-03-07T23:07:46Z

arclight_installer.go

+}
+
+func (r *ArclightInstaller) InstallWithLoader(path, name string, target string, loader string) (installed string, err error) {
+	data, err := r.GetInstallerVersions()


data 这个名字太笼统了，换成 versions

zyxkad · 2024-03-29T20:49:04Z

README.MD

@@ -83,7 +83,7 @@ minecraft_installer -name minecraft_server -version 1.19.2 -server fabric -path
 ```

 ```sh
-# Install papermc 1.14.4 server into {PATH}/server-1.14.4-{BUILDNUM}/{PAPERMC-INSTALLED-NAME}.jar
+# Install papermc 1.14.4 server into server/minecraft_server.jar


Suggested change

# Install papermc 1.14.4 server into server/minecraft_server.jar

# Install papermc 1.14.4 server into minecraft_server.jar

zyxkad approved these changes Mar 7, 2024

View reviewed changes

Fellsoul added 3 commits March 7, 2024 15:18

Add supports for Papermc and Arclight

f51a0e4

update supports for papermc and arclight

d8c50dc

add support for papermc and arclight

f7e297f

zyxkad force-pushed the papermc-arclight branch from c912b19 to f7e297f Compare March 7, 2024 22:18

fix go vet error

4e38ddf

zyxkad self-requested a review March 7, 2024 22:22

zyxkad requested changes Mar 7, 2024

View reviewed changes

zyxkad reviewed Mar 7, 2024

View reviewed changes

Update README.MD

197373b

zyxkad requested changes Mar 29, 2024

View reviewed changes

Update README_zh.MD

850ed81

Fellsoul closed this Mar 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Papermc arclight #1

Papermc arclight #1

Fellsoul commented Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

Fellsoul Mar 11, 2024

zyxkad Mar 7, 2024

Fellsoul Mar 11, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

Fellsoul Mar 11, 2024

zyxkad Mar 7, 2024

Fellsoul Mar 11, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

zyxkad Mar 7, 2024

Fellsoul Mar 11, 2024

zyxkad Mar 7, 2024

Fellsoul Mar 11, 2024

zyxkad Mar 29, 2024

	for i := 0; i < len(releases); i += 1 {
	for _, release := range releases {

	if data[allVersions[i]].IsExpired == true {
	if data[allVersions[i]].IsExpired {

	for i := 0; i < len(allVersions); i += 1 {
	for _, version := range allVersions {

	for i := 0; i < len(allVersions); i += 1 {
	for version, _ := range data {

	var releases []ArclightRelease
	var releases []*ArclightRelease

	if data[loader].IsExpired == true {
	if version, ok := data[loader]; ok && version.IsExpired {

	# Install papermc 1.14.4 server into server/minecraft_server.jar
	# Install papermc 1.14.4 server into minecraft_server.jar

Papermc arclight #1

Papermc arclight #1

Conversation

Fellsoul commented Mar 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment