Outbox prisma adapter #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilwylegala
force-pushed
the
AP-5046-outbox-prisma-adapter
branch
from
9ffbf8c to
963014a
Compare
kibertoad
reviewed
Nov 26, 2024
| const prismaModel: PrismaClient[typeof this.modelName] = this.prisma[this.modelName] | ||
|
|
||
| for (const entry of entries) { | ||
| await prismaModel.upsert({ |
There was a problem hiding this comment.
upserts often have suboptimal performance with plenty of locking, can we somehow simplify this to be bulk inserts and bulk updates?
There was a problem hiding this comment.
Definitely. I'm working on making tests green. Once I cover all cases, Bulk update/insert would do the job.
Actually upsert has some weird behavior, maybe let's switch to bulk inserts/updates right away.
kamilwylegala
commented
Nov 28, 2024
| ): Promise<OutboxEntry<SupportedEvents[number]>> { | ||
| const prismaModel = this.prisma[this.modelName] as unknown as ModelDelegate | ||
|
|
||
| // @ts-ignore |
There was a problem hiding this comment.
TODO: remove it later, added now to just move forward with the CI and setting up tests there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactional outbox pattern adapter for Prisma.