Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Authorization #37

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dharnitski
Copy link

@dharnitski dharnitski commented May 8, 2015

Hi Kevin,

Please check my implementation for token based authorization.

This pull request includes:

  • Token security
  • xUnit upgrade to 2.0
  • fix for HttpHandler Authorization. Service executed the request even if Authorization failed (with returning 401).
  • Unit tests for new feature and Authorization in Nancy middleware

I checked Unit tests, Smoke tests and Code analysis - everything looks good.
Hope that we can see this enchantment in Nugget soon.

Thanks
Dmitry


This change is Reviewable

@kevinobee
Copy link
Owner

Thanks so much for the work Dmitry. Apologies for taking so long to respond to you, the day job has been keeping me busy.

I will look through your commits and try to get this in as soon as possible, pending feedback.

Thanks again for the great work

@kevinobee kevinobee self-assigned this Sep 5, 2015
@dharnitski
Copy link
Author

Hi Kevin,

Please let me know if there is anything I can help you with to merge this request.

Thanks
Dmitry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants