-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update rollup to exclude es5-ext #243
Conversation
Can you verify whether there are any breaking changes we need to address? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 63.14% 63.14%
=======================================
Files 21 21
Lines 605 605
Branches 228 228
=======================================
Hits 382 382
Misses 182 182
Partials 41 41 ☔ View full report in Codecov by Sentry. |
CI passed, but I don't have the bandwidth to verify there were no issues outside of the automated checks and I would like someone to go through the changelog of the various tools to make sure there's nothing we need to handle. Once that's done I can merge. |
Hey @kentcdodds Thank you for the quick response. I will try and check. |
Okay I have done the following:
I concluded that the directories are the same, there are no defined changes to the bundled code. If you want to double check please do. I hope this answers your doubt. cc: @kentcdodds (Sorry for the ping) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting the work into this!
🎉 This PR is included in version 15.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Awesome, thanks for the quick response. |
What:
Why:
How:
Checklist:
closes #242