Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rollup to exclude es5-ext #243

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Sembauke
Copy link
Contributor

@Sembauke Sembauke commented Feb 21, 2024

What:

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

closes #242

@kentcdodds
Copy link
Owner

Can you verify whether there are any breaking changes we need to address?

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04d2732) 63.14% compared to head (27ff155) 63.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   63.14%   63.14%           
=======================================
  Files          21       21           
  Lines         605      605           
  Branches      228      228           
=======================================
  Hits          382      382           
  Misses        182      182           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kentcdodds
Copy link
Owner

CI passed, but I don't have the bandwidth to verify there were no issues outside of the automated checks and I would like someone to go through the changelog of the various tools to make sure there's nothing we need to handle. Once that's done I can merge.

@Sembauke
Copy link
Contributor Author

Sembauke commented Feb 21, 2024

Hey @kentcdodds

Thank you for the quick response. I will try and check.

@Sembauke
Copy link
Contributor Author

Okay I have done the following:

  1. I created a new directory named "Compare"
  2. I ran npm run build on this chore branch
  3. I moved the generated dist folder to the compare folder
  4. I ran git checkout on the main branch and did the same step 1 through 3 but named it dist_old
  5. Then I compared the two directories (and sub-directories) with this macOS command: diff -qr dist dist_old

I concluded that the directories are the same, there are no defined changes to the bundled code. If you want to double check please do. I hope this answers your doubt.

cc: @kentcdodds (Sorry for the ping)

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting the work into this!

@kentcdodds kentcdodds merged commit e68fecc into kentcdodds:main Feb 21, 2024
9 checks passed
Copy link

🎉 This PR is included in version 15.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sembauke Sembauke deleted the fix/update-rollup branch February 22, 2024 07:26
@Sembauke
Copy link
Contributor Author

Awesome, thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade rollup to the latest version
2 participants