feat: error handling on ticks #861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ added error handling function param on a new constructor + added the function param on the static `from` method + caught the errors in the callback method
+ removed `@ts-expect-error line` bc it was throwing error itself
JosephVoid
changed the title
feat: error handling on job.start()job.start()
JosephVoid
changed the title
job.start()job.start()
sheerlox
requested changes
Mar 7, 2024
+ Instead of a new constructor, I added the `errorHandler` on every other constructor + removed the superflous if checks + added `errorHandler` on every `return new CronJob`
|
Hey @sheerlox, Thanks for the review. I've incorporated all the suggestions. |
sheerlox
previously approved these changes
Mar 8, 2024
sheerlox
force-pushed
the
feature/error-handling
branch
from
b3902a9 to
f13aba2
Compare
sheerlox
changed the title
job.start()
|
Hey, any news on this being merged into main? |
|
hello, I'm currently working on the |
|
I submitted a PR to this branch to fix the merge conflicts. @JosephVoid if you can merge it then this PR will be ready for a final review |
|
actually I think I submitted the PR to the wrong branch. new one here. if it works then it should show this merge conflict as fixed |
intcreator
approved these changes
Dec 17, 2024
sheerlox
approved these changes
Dec 18, 2024
|
Excellent work @JosephVoid, thank you for taking on this feature request! Thanks @intcreator also for taking over the review 😄 |
|
Looks like the tests aren't passing, if someone wants to look into it so we can merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added an error handling method in the
CronJobclass and added it to the constructors parameters. This error handling method will be called if any exception is thrown from theonTickmethod. Also added two new tests to confirm that it works.Related Issue
Closes #426.
Motivation and Context
If any kind of exception occurs from the
onTickmethod the whole process stops currently. To solve this, this feature will allow users to pass their own error handler when exceptions occur.How Has This Been Tested?
Added two new test cases called
should catch errors if errorhandler is provided&should throw errors if errorhandler is NOT providedScreenshots (if appropriate):
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).