Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't serve requests with incorrect or empty Host header #63

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Don't serve requests with incorrect or empty Host header #63

wants to merge 11 commits into from

Conversation

rmrio
Copy link

@rmrio rmrio commented Sep 16, 2015

Generally is not a good idea to serve all requests on the blog IP even with empty or unknown host header. The good practice is to serve requests with correct 'Host' header and return 400 otherwise.
See rfc2616 for details.

@kabukky
Copy link
Owner

kabukky commented Nov 10, 2015

Hi rmrio,
thanks for your PR. Could you submit it again against the development branch? The master branch is just updated with releases. I will update the readme to reflect this.

A couple of things:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants