forked from devlooped/ThisAssembly
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from devlooped:main #18
Open
pull
wants to merge
161
commits into
justinwritescode:main
Choose a base branch
from
devlooped:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [Scriban](https://github.com/scriban/scriban) from 5.9.1 to 5.10.0. - [Release notes](https://github.com/scriban/scriban/releases) - [Changelog](https://github.com/scriban/scriban/blob/master/changelog.md) - [Commits](scriban/scriban@5.9.1...5.10.0) --- updated-dependencies: - dependency-name: Scriban dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the tests group with 3 updates: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest), [xunit](https://github.com/xunit/xunit) and [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit). Updates `Microsoft.NET.Test.Sdk` from 17.7.2 to 17.9.0 - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.7.2...v17.9.0) Updates `xunit` from 2.6.6 to 2.8.0 - [Commits](xunit/xunit@2.6.6...2.8.0) Updates `xunit.runner.visualstudio` from 2.5.6 to 2.8.0 - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](xunit/visualstudio.xunit@2.5.6...2.8.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tests - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tests - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tests ... Signed-off-by: dependabot[bot] <[email protected]>
# devlooped/oss - Upload binlog artifact on debug runs devlooped/oss@a67ae78 - Set env:gh_token if present as secret devlooped/oss@97ebd18 - Add static usings to allow unprefixed ThrowXxxx devlooped/oss@6dfe21f - Only ignore App folder directly under the root devlooped/oss@02811fa - Bump create-pr dependency to avoid error with existing PRs devlooped/oss@11a8757 - Only commit markdown files when resolving includes devlooped/oss@2c10a83 - Update dotnet-file.yml with fix to create pull request action devlooped/oss@11a331d
Bumps [NuGetizer](https://github.com/devlooped/nugetizer) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/devlooped/nugetizer/releases) - [Changelog](https://github.com/devlooped/nugetizer/blob/main/changelog.md) - [Commits](devlooped/nugetizer@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: NuGetizer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the tests group with 3 updates in the / directory: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest), [xunit](https://github.com/xunit/xunit) and [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit). Updates `Microsoft.NET.Test.Sdk` from 17.9.0 to 17.10.0 - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.9.0...v17.10.0) Updates `xunit` from 2.8.0 to 2.8.1 - [Commits](xunit/xunit@2.8.0...2.8.1) Updates `xunit.runner.visualstudio` from 2.8.0 to 2.8.1 - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](xunit/visualstudio.xunit@2.8.0...2.8.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tests - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch dependency-group: tests - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch dependency-group: tests ... Signed-off-by: dependabot[bot] <[email protected]>
# devlooped/oss - Update to checkout@v4 devlooped/oss@5fb1723 - Don't add random wait on manual dotnet-file runs devlooped/oss@7afe350 - Add compatibility for non-SDK projects without InitializeSourceControlInformation target devlooped/oss@6e96c59
Just as we do for explicit comment. Fixes #308
* ⬆️ Bump files with dotnet-file sync # devlooped/oss - Add our implementation of JWT manifest reading and reporting devlooped/oss@a0ae727 - Integrate more seamlessly with the existing workflows devlooped/oss@e732f6a - Add copylocal behavior when merging assemblies devlooped/oss@7cda4a1 - Use org profile links for diagnostics devlooped/oss@b03392d - Whitespace and formatting devlooped/oss@d74f511 - Minimal docs on consuming devlooped/oss@827a1d1 - Simplify and unify manifest reading implementation devlooped/oss@4fca946 - Ignore sponsorlink sources in formatting devlooped/oss@f571a42 - Add CI for SponsorLink analyzer devlooped/oss@45595a0 - Remove unused legacy nuget.org devlooped/oss@17871a3
Instead of linked files which is less intuitive and manageable.
…tants This allows us to support Comment attribute, but more importantly, support hierarchical metadata ids to generate the nested class structure like we have in Constants. Fixes #247
The following are now valid and produce the expected results, just as an equivalent interpolated string would: - `expires on {date:yyyy-MM-dd}` - `expires on year {date:yyyy} (wait until {date:MM}` - `expires on {0:yyyy-MM}` Note how the same argument name can be used multiple times with different output formatting for increased flexibility and arg reuse. Fixes #299
# devlooped/oss - Dynamically fetch devlooped JWK from github devlooped/oss@55124bc - Fix path to jwk.ps1 alongside the SponsorLink.targets devlooped/oss@c4830fc - SponsorLink code should be checked as regular code devlooped/oss@e81ab75 - Update help messages for renamed tool devlooped/oss@c5530c4 - Update for renamed tool sponsors devlooped/oss@d4af445 - Add @ before account, unify es messages devlooped/oss@1c7fd8d - Set Version from VersionLabel if it's a refs/tags/ devlooped/oss@57653a2 - Revert back to dotnet-sponsor devlooped/oss@8d29f01 - Cleanup build and publish to use VersionLabel devlooped/oss@14deaea - Switch to the dotnet global tool version of SL CLI devlooped/oss@cff07df - Switch to renamed sponsorlink > sponsor devlooped/oss@d5efe5e - Bump to renamed tool devlooped/oss@b8fd87b - Improve versioning of sample package devlooped/oss@3b943f5
# devlooped/oss - Remove dependency on ThisAssembly devlooped/oss@c879f25 - Rename sample assemblies for nicer display devlooped/oss@93df7c7
# devlooped/oss - Fix scenario where multiple packages share product name devlooped/oss@23f83bd - SponsorLink-enabled analyzers need copylocal devlooped/oss@7593657 - Minor code simplification devlooped/oss@cf154d5
This is a workaround (fix?) for dotnet/roslyn#51692, basically. We lose all content after the first semicolon in constant and metadata values (presumably Git too). Project properties also suffer from this, but merits unifying it with ThisAssembly.Constants to continue to streamline the implementation.
# devlooped/oss - Add targets for inclusion from tests devlooped/oss@81ba912
# devlooped/oss - Update to newest JsonWebTokens devlooped/oss@068140b - Add support and showcase determining install time devlooped/oss@717ddb1 - Switch to built-in item metadata for manifest analyzer files devlooped/oss@49c9a38 - Change debug traces location to the well-known location of .sponsorlink devlooped/oss@1019e2a
# devlooped/oss - Update to newest JsonWebTokens devlooped/oss@068140b - Add support and showcase determining install time devlooped/oss@717ddb1 - Fix formatting/whitespace devlooped/oss@7febebc - Switch to built-in item metadata for manifest analyzer files devlooped/oss@49c9a38 - Extend grace period to unknown status too devlooped/oss@9f918ec - Change debug traces location to the well-known location of .sponsorlink devlooped/oss@1019e2a - Remove unused tracing overloads devlooped/oss@08a8488 - Fix roles checking from new identity-based token handler devlooped/oss@6eecf46
# devlooped/oss - Update to newest JsonWebTokens devlooped/oss@068140b - Add support and showcase determining install time devlooped/oss@717ddb1 - Fix formatting/whitespace devlooped/oss@7febebc - Switch to built-in item metadata for manifest analyzer files devlooped/oss@49c9a38 - Extend grace period to unknown status too devlooped/oss@9f918ec - Replace JWT package in tests targets too devlooped/oss@ba1310c - Change debug traces location to the well-known location of .sponsorlink devlooped/oss@1019e2a - Remove unused tracing overloads devlooped/oss@08a8488 - Fix roles checking from new identity-based token handler devlooped/oss@6eecf46
# devlooped/oss - Update to newest JsonWebTokens devlooped/oss@068140b - Add support and showcase determining install time devlooped/oss@717ddb1 - Fix formatting/whitespace devlooped/oss@7febebc - Switch to built-in item metadata for manifest analyzer files devlooped/oss@49c9a38 - Extend grace period to unknown status too devlooped/oss@9f918ec - Replace JWT package in tests targets too devlooped/oss@ba1310c - Change debug traces location to the well-known location of .sponsorlink devlooped/oss@1019e2a - Remove unused tracing overloads devlooped/oss@08a8488 - Add SponsorLinkImported so we can skip imports devlooped/oss@c81f532 - Fix roles checking from new identity-based token handler devlooped/oss@6eecf46
# devlooped/oss - Introduce lazy-init of sponsoring status, simplify diagnostics devlooped/oss@5009784 - Update to newest JsonWebTokens devlooped/oss@068140b - Add support and showcase determining install time devlooped/oss@717ddb1 - Fix formatting/whitespace devlooped/oss@7febebc - Switch to built-in item metadata for manifest analyzer files devlooped/oss@49c9a38 - Fix roles checking from new identity-based token handler devlooped/oss@6eecf46 - Extend grace period to unknown status too devlooped/oss@9f918ec - Replace JWT package in tests targets too devlooped/oss@ba1310c - Add SponsorLinkImported so we can skip imports devlooped/oss@c81f532 - Make sure Funding class is available to intellisense devlooped/oss@5813f21 - Change debug traces location to the well-known location of .sponsorlink devlooped/oss@1019e2a - Remove unused tracing overloads devlooped/oss@08a8488
# devlooped/oss - Add our implementation of JWT manifest reading and reporting devlooped/oss@a0ae727 - Remove dependency on ThisAssembly devlooped/oss@c879f25 - Make sure we report only once per product for entire solution devlooped/oss@4b7f922 - Add support and showcase determining install time devlooped/oss@717ddb1 - Update to newest JsonWebTokens devlooped/oss@068140b - Dynamically fetch devlooped JWK from github devlooped/oss@55124bc - Rename sample assemblies for nicer display devlooped/oss@93df7c7 - Introduce lazy-init of sponsoring status, simplify diagnostics devlooped/oss@5009784 - Minimal docs on consuming devlooped/oss@827a1d1 - Whitespace and formatting devlooped/oss@d74f511 - Make sure Funding class is available to intellisense devlooped/oss@5813f21 - Remove unused tracing overloads devlooped/oss@08a8488 - Simplify and unify manifest reading implementation devlooped/oss@4fca946 - Add nullable and generated code annotations devlooped/oss@b2a11fa - Improve versioning of sample package devlooped/oss@3b943f5 - Fix path to jwk.ps1 alongside the SponsorLink.targets devlooped/oss@c4830fc - Replace JWT package in tests targets too devlooped/oss@ba1310c - Fix formatting/whitespace devlooped/oss@7febebc
# devlooped/oss - Update sponsor.yml to use org-access token devlooped/oss@96ca2b1
This can help workaround the issue of the value having invalid content for an XML summary element (i..e. the value has XML). Further fixes #390
We were missing this since the SDK defaults the specific attributes to `true` only if the overall flag `GenerateAssemblyInfo` is `true`. We change that in our targets, but without forcing `GenerateAssemblyInfo=true`. This allows to turn off codegen, but still get the attributes as items. Fixes #407
This is important in particular when we add intermediate automatic "area" classes (such as when a constant is Foo.Bar.Baz), since in those cases, the user has no way of specifying a comment to fix the issue.
This ensures we get valid XML doc comments, rather than potentially nested (invalid) XML if the property happens to contain XML.
We don't actually retrieve hand-coded attbutes in code, only MSBuild items.
Since this project provides most of the behavior now.
# devlooped/oss - Update .gitignore to ignore .genaiscript devlooped/oss@e0be248 # devlooped/SponsorLink - Bump the identity group across 4 directories with 1 update devlooped/SponsorLink@58d0ece - Bump the tests group across 2 directories with 3 updates devlooped/SponsorLink@03b9453 - Bump the extensions group across 3 directories with 5 updates devlooped/SponsorLink@b75813d - Manually bump dependencies for now since dependabot doesn't devlooped/SponsorLink@1f083cf - Bump dependencies devlooped/SponsorLink@f74ea7a - Remove unnecessary duplicate package reference devlooped/SponsorLink@e554253
Since it's now just a configurator for ThisAssembly.Constants
It's now akin to AssemblyInfo/Git/Vsix, with no code in itself.
# devlooped/SponsorLink - Bump the identity group across 2 directories with 1 update devlooped/SponsorLink@0d22f1e - Bump dependency on JWT assembly to fix STJ vulnerability devlooped/SponsorLink@b7450e6 - Unify JWT dependencies devlooped/SponsorLink@fb82cf3
If source control information is supported, make sure we automatically take a dependency on InitializeSourceControlInformation. We take the chance to also rename the old property `InjectThisAssemblyProjectDependsOn` to `PrepareProjectPropertiesDependsOn` which aligns better with the new target.
When changing it.
This follows the pattern we have in other packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )