-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds jupyter-ui-toolkit packages in shared scope #7530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Left a minor comment, otherwise looks good 👍
app/package.json
Outdated
@@ -12,6 +12,8 @@ | |||
"resolutions": { | |||
"@codemirror/state": "~6.4.1", | |||
"@codemirror/view": "~6.28.3", | |||
"@jupyter/react-components": "^0.16.6", | |||
"@jupyter/web-components": "^0.16.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can move the @jupyter/ydoc
line below next to these new packages, so it's easier to notice (and somewhat sorted) while looking at the resolutions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I moved the new entries instead to follow the ASCII order.
Since the corresponding PR in jupyterlab has been published in 4.1, we should probably backport this one to |
I guess it would be fine to backport to |
@meeseeksdev please backport to 7.2.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
I can do it |
ah meeseek was not able to do the backport, hopefully the manual backport is not too painful since it's just a few lines. |
This PR adds the 2 packages from jupyter-ui-toolkit in the shared scope of Notebook.
These packages have been included in jupyterlab as singleton in jupyterlab/jupyterlab@3d525a2.
Without this change, an extension depending on one of these packages would not work.
Thanks @jtpio for your help on this.