Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy marked.umd.js to marked.js and revert loading #236

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

echarles
Copy link
Member

@echarles echarles commented Mar 27, 2023

Fixes #227

This revert the changes introduced in #201. Instead of loading from umd file, we load from javascript as before, and we copy the marked.umd.js file to marked.js after bower has pulled the dependencies.

This also solves Jupyter-contrib/jupyter_nbextensions_configurator#152

@echarles echarles marked this pull request as draft March 27, 2023 08:13
@echarles echarles changed the title Copy marked.cjs to marked.js and revert loading Copy marked.umd.js to marked.js and revert loading Mar 27, 2023
@echarles echarles marked this pull request as ready for review March 27, 2023 08:33
Copy link
Collaborator

@ericsnekbytes ericsnekbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks good, approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbclassic >=0.5 breaks jupyter_nbextensions_configurator
2 participants