Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsconfig #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasongrout
Copy link
Contributor

Adding the rootDir option means that the output files will be in lib/ instead of lib/src. I also removed the redundant lib settings, given that we now have an es2105 target.

Adding the rootDir option means that the output files will be in `lib/` instead of `lib/src`. I also removed the redundant lib settings, given that we now have an es2105 target.
@jasongrout
Copy link
Contributor Author

(I didn't test the build after making these changes - presumably the automated tests will do that.)

@maartenbreddels
Copy link
Contributor

It gives this error:

error TS6059: File '/Users/maartenbreddels/src/ipysheet/js/package.json' is not under 'rootDir' '/Users/maartenbreddels/src/ipysheet/js/src'. 'rootDir' is expected to contain all source files.

Odd thing is, with ipyvolume it does go to lib, and not lib/src, without this option. Good to know we could get rid of the libs.

@maartenbreddels
Copy link
Contributor

Reading https://github.com/Microsoft/TypeScript/wiki/FAQ#why-does---outdir-moves-output-after-adding-a-new-file for some reasons the longest common prefix in ipyvolume is longer.
Very unnatural behavior I'd say.

@martinRenou
Copy link
Contributor

Thanks Jason, the output files issue was actually due to the json package, I fixed it in #87. Maybe you can remove the rootDir change and only keep the removal of the redundant lib settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants