-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting intro into two tutorials #714
base: main
Are you sure you want to change the base?
Splitting intro into two tutorials #714
Conversation
order.json
Outdated
@@ -4,7 +4,8 @@ | |||
"contributing", | |||
{ | |||
"about-jquery": [ | |||
"how-jquery-works", | |||
"how-to-setup-jquery", | |||
"using-jquery", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a spacing problem here.
Hey @AurelioDeRosa Thank you for the feedback! I've updated the pages taking into account all of the changes you suggested 👍 I'll give the pages another read through soon to see if there's anything else that can be improved. |
Let me know when you're done so that I can have a final look and then merge it. |
Hey @AurelioDeRosa I've updated both pages a little bit, should be good to 🚢 |
order.json
Outdated
@@ -4,8 +4,9 @@ | |||
"contributing", | |||
{ | |||
"about-jquery": [ | |||
"how-jquery-works", | |||
"additional-support" | |||
"how-to-setup-jquery", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using tabs but we use spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now
Fixes #658
Closes #661
Hey guys @AurelioDeRosa @agcolom @gnarf @arthurvr
I'd like to continue on from #661 and hopefully get these new pages setup soon - I'll be giving them a good read through tomorrow (and double checking that all issues raised have already been amended) but any edits we want made I can do ASAP 👍
I've made a minor amend (fixing references to
main.js
that should have beendemo.js
) and hope to improve the files as much as possible.