css: Document no auto-appending px in jQuery 4.0
#1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, document the removal of `jQuery.cssNumber` in jQuery 4.0.
|
This is a new version of #1260. |
mgol
commented
Dec 16, 2024
Comment on lines
-16
to
-27
| <li><code>zIndex</code></li> | ||
| <li><code>fontWeight</code></li> | ||
| <li><code>opacity</code></li> | ||
| <li><code>zoom</code></li> | ||
| <li><code>lineHeight</code></li> | ||
| <li><code>widows</code> (added in jQuery 1.6)</li> | ||
| <li><code>orphans</code> (added in jQuery 1.6)</li> | ||
| <li><code>fillOpacity</code> (added in jQuery 1.6.2)</li> | ||
| <li><code>columnCount</code> (added in jQuery 1.9)</li> | ||
| <li><code>order</code> (added in jQuery 1.10.2)</li> | ||
| <li><code>flexGrow</code> (added in jQuery 1.11.1)</li> | ||
| <li><code>flexShrink</code> (added in jQuery 1.11.1)</li> |
There was a problem hiding this comment.
I removed it, but we could consider leaving the list in and updating the new values we added. But it's easy to just check what you have in your jQuery version and if you maintain a library, you shouldn't rely on this list anyway and just pass strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, document the removal of
jQuery.cssNumberin jQuery 4.0.jQuery.cssNumberis a weird API as it was never deprecated since jQuery3.xuses it but jQuery4.0.0will not need it.