-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(algorithm): updated matAlgo07xSSf algorithm to return sparse matrix #3307
Conversation
@Aakash-Rana Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 13! @josdejong received 25 Sloth Points for reviewing and scoring this pull request. Congratulations @Aakash-Rana! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Hello. First of all, sorry for hopping in the PR. |
Thanks @Aakash-Rana, this is a neat fix! I'll merge this PR into the first next major version |
🥁 Score it! @josdejong, please score the PR with |
Hello @josdejong |
@race-of-sloths score 13 |
Published now in |
Updated
matAlgo07xSSf
algorithm and fixed #3219This PR addresses an issue in the
matAlgo07xSSf
algorithm, where the result of any operation on two sparse matrices returning a dense matrix instead of preserving the sparse matrix format. This functionmatAlgo07xSSf
is utilized by various functions such as dotDivide , dotPow , bitXor , larger , smaller , equal , xor , smallerEq etc - to perform operations on sparse matrices.The update ensures that the result of any sparse-sparse operation is correctly returned as a sparse matrix, maintaining consistency with the input types.
Changes:
matAlgo07xSSf
algorithm to handle operations of sparse-sparse matrix ensuring only non-zero or true results are stored.@race-of-sloths Include this PR