Added BEANSTALK_JOB_NAME pattern functionality to BeanstalkClient.call() #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2011 16:36
…o derive the function name if appname and jobname parameters are passed
…nding pickled data through the arg, and logger doesn't like printing that. Not sure if its a good idea to send pickled objects as beanstalk job arguments, will investigate further
|
Sorry for not getting back to you sooner. Looks good to me but I'll have to test it on my development machine. I'll let you know as soon as I tried it out. |
|
Yeah, looks like this pull request included two commits, I was trying to only submit the last one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeanstalkClient.call() will use settings.BEANSTALK_JOB_NAME pattern to derive the function name if appname and jobname parameters are passed
Makes it easier for folks like me to manage staging and production servers with the same code base. I don't have to write special code to switch the function name given the deployment environment.
Also added some documentation to make the feature a bit clearer.
Note: I tried to select just one commit for this pull request, and to ignore some other changes I've made on my fork. I'm curious if I'm using this github feature correctly. If you decide to pull my changes, please let me know if it works.