Skip to content

Commit

Permalink
ci: Do not persist credentials after checkout
Browse files Browse the repository at this point in the history
See actions/checkout#485 and https://johnstawinski.com/2024/01/11/playing-with-fire-how-we-executed-a-critical-supply-chain-attack-on-pytorch/

In short, it is a terrible idea to persist even our default credentials after checkout. There's no call for that, so we will now set `persist-credentials: false` on all checkout actions.
  • Loading branch information
joeyparrish committed Dec 18, 2024
1 parent 100fc8a commit be98706
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
with:
path: repo-src
ref: ${{ inputs.ref || github.ref }}
persist-credentials: false

- name: Configure Build Matrix
id: configure
Expand Down Expand Up @@ -150,6 +151,7 @@ jobs:
with:
path: repo-src
ref: ${{ inputs.ref || github.ref }}
persist-credentials: false

- name: Install OS packages
run: ./repo-src/build-scripts/00-packages.sh
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
with:
path: repo-src
ref: ${{ github.ref }}
persist-credentials: false

- uses: actions/download-artifact@v4
with:
Expand Down

0 comments on commit be98706

Please sign in to comment.