TimeExtensions.cs #213
Open
TimeExtensions.cs #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added null checks and exception handling to prevent runtime errors. Improved conditional logic in the IsBetween method. Added XML documentation comments for better code readability and maintainability. Improved string parsing in ToTimeOfDay with robust error handling.
|
What if instead Time is changed to a Struct? I would prefer to not be able to be null rather than propagating null checks everywhere |
|
Ohh yess you're right we can do that, and also it would be really grateful if you give me credit as well |
|
your username will forever be recorded on the commit history of this repo and joining the Contributers list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added null checks and exception handling to prevent runtime errors. Improved conditional logic in the IsBetween method. Added XML documentation comments for better code readability and maintainability. Improved string parsing in ToTimeOfDay with robust error handling.