Add include path to target #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If these are public libraries a client build system needs to link to them again even libcitygml was compiled into a self-contained dynamic library.
gostefan
force-pushed
the
addIncludePathToTarget
branch
from
e4d1644 to
68d11ab
Compare
gostefan
force-pushed
the
addIncludePathToTarget
branch
from
68d11ab to
8783e62
Compare
|
Had to rebase this on the fixed version of PR #98. The two relevant commits still have the same contents. |
CMake's install will combine the relative path with the absolute path passed via CMAKE_INSTALL_PREFIX. This shouldn't be handled in CMakeLists.txt files. The state before resulted in absolute paths being used in citygmlConfig.cmake. That prohibits prebuilding the library and deploying it on other machines/paths.
It's unclear why the lib install folders worked without this before. But now the CMake files get correctly installed.
With this a library user can just use target_link_libraries(citygml::citygml) and the include directories are set up automatically.
When it's at the end CMake treats and as additional include directories when generating the citygmlConfigInternal.cmake file. This is clearly wrong.
gostefan
force-pushed
the
addIncludePathToTarget
branch
from
8783e62 to
c657724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users of libcitygml to write simpler cmake files. They will only need
target_link_libraries(citygml::citygml). (Plus finding the package of course.)This PR is only about the last two commits. The others are included in other PRs (#96, #97, and #98). This PR is based on them to avoid conflicts when merging.