Preserve signature with change in screen orientation and size #612
Conversation
|
|
|
Sorry, didn't mean to close it. |
|
Do I need to resolve bundle conflicts? If so, what's the procedure for that? |
When user has signed at < 175% zoom and zooms to 175%+, parts of the signature get cut off. This is a nonissue when going the other way.
Also add updated bundles because having outdated ones on there bugs me.
There was a problem hiding this comment.
LGTM, tested this a bit, and this looks really great! I didn't even have problems with zoom, and orientation changing works great too.
Do I need to resolve bundle conflicts? If so, what's the procedure for that?
I did a quick rebase; there aren't really conflicts with app.js, the only file that you changed, so if you just rebase everything, ignoring the conflicts of bundle.js, no jquery, and wrap jquery, and then re-download them from localhost.
If you want to, you should be able to checkout out the branch I made, set your branch to it, and then force push.
git remote add brycestevenwilley [email protected]:BryceStevenWilley/docassemble
git fetch --all
git checkout preserve_canvas # this branch
git reset --hard preserve_canvas_2
git push --force origin preserve_canvas
|
Done. Maybe a new bundle.js rebase is needed. I assume I just rebase to master? |
|
Yeah, the branch I made probably got stale since making it. |
This works in most cases - the ones that seem most likely. When the user has signed at < 175% zoom and zooms to 175%+, parts of the signature go off screen. This is a nonissue when going the other way.
If this isn't get acceptable, I can keep working on it.
Sorry about the changed compiled files. They're not up to date with the latest changes as I was trying not to commit them, but I must have committed them accidentally at some point. Let me know if I need to reset them.