Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting key for Total table header #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

democat3457
Copy link

@democat3457 democat3457 commented Dec 9, 2024

When clicking the --- Total --- header in the Delta-focused stats table, the table doesn't sort by the completion time.
image

This is because the sorting key provided when creating the Total header has a different sorting key than the Points header does. Changing the key from "total" to "completion" to match the sorting key of the Points header fixes the sorting.

@jeroenheijmans
Copy link
Owner

Oh my that's broken indeed! Thanks for the PR, that helps a ton. I do have some personal stuff going on, so not sure when I'll get to releaseing it (the check + merge is easily done soon, but building and releasing the addon in stores is a bit of manual labor at the moment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants