Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Yahoo UI usages from support-core plugin #603

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

sandeepbarnwal
Copy link
Contributor

@sandeepbarnwal sandeepbarnwal commented Dec 18, 2024

Changes

  • Replaced yui button references with jenkins-button

Note: button location got changed (renders on left side now) after using jenkins-button css and it seemed more in line with the other buttons. Hence, I didn't put effort to keep it in original location and would change if required after the reviews.

Testing done

Before
image

After
image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…tton location to make it ocnsistent with other buttons
@sandeepbarnwal sandeepbarnwal requested a review from a team as a code owner December 18, 2024 06:09
@batmat
Copy link
Member

batmat commented Dec 18, 2024

@sandeepbarnwal the difference between before and after screenshot wrt. bundle namings sounds surprising (and very different). Did you test it with the same instance?

@sandeepbarnwal
Copy link
Contributor Author

@sandeepbarnwal the difference between before and after screenshot wrt. bundle namings sounds surprising (and very different). Did you test it with the same instance?

thanks for the observation. It was from different insrance (from modern setup in local machine). Now, I've update the before screenshot that matches with the after one.

@batmat batmat changed the title BEE-53476 Removes Yahoo UI usages from support-core plugin Removes Yahoo UI usages from support-core plugin Dec 18, 2024
@jglick jglick added this pull request to the merge queue Dec 18, 2024
Merged via the queue into jenkinsci:master with commit 39e20b2 Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants