API to supersede components if not required #601
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
changed the title
jglick
reviewed
Dec 17, 2024
| @@ -153,6 +153,10 @@ public ComponentCategory getCategory() { | |||
| return ComponentCategory.UNCATEGORIZED; | |||
| } | |||
|
|
|||
| public Set<Class<? extends Component>> getSupersededComponents() { | |||
| return Collections.emptySet(); | |||
There was a problem hiding this comment.
or just
Suggested change
| return Collections.emptySet(); | |
| return Set.of(); |
jglick
reviewed
Dec 17, 2024
| @@ -153,6 +153,10 @@ public ComponentCategory getCategory() { | |||
| return ComponentCategory.UNCATEGORIZED; | |||
| } | |||
|
|
|||
| public Set<Class<? extends Component>> getSupersededComponents() { | |||
jglick
reviewed
Dec 17, 2024
| for (Component component : components) { | ||
| try { | ||
| if (supersededComponents.contains(component.getClass())) { |
There was a problem hiding this comment.
The use of Class in APIs is usually a bit of an antipattern since it makes assumptions about implementation hierarchies; and actually @Extension is not strictly limited to singleton classes. Maybe a boolean supersedes(Component)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way for components to supersede other components in the support bundle creation process