Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss missing permission check alerts in form validation methods #78

Merged

Conversation

mig42
Copy link
Contributor

@mig42 mig42 commented Aug 22, 2024

This PR dismisses the following security alerts:

Those were false positives. The method in CmTool performs the permissions check inside FormValidation.validateExecutable(), and the other methods only check whether the incoming values match the expectd format. They don't access sensitive information.

Testing done

Not needed. This PR only adds @SuppressWarnings annotations.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

mig42 added 2 commits August 22, 2024 09:50
The permissions check is already performed by
`FormValidation.validateExecutable()`.

Signed-off-by: Miguel González <[email protected]>
These methods aren't accessing sensitive information, just checking that
the input values match the expected format.

Signed-off-by: Miguel González <[email protected]>
@mig42 mig42 changed the title Miguel/fix security alerts/missing permission checks Dismiss missing permission check alerts in form validation methods Aug 22, 2024
@pablobayarri pablobayarri merged commit cc3976a into master Aug 22, 2024
16 checks passed
@pablobayarri pablobayarri deleted the miguel/fix-security-alerts/missing-permission-checks branch August 22, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants