Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for icon on sidebar report action #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonesbusy
Copy link

@jonesbusy jonesbusy commented Nov 30, 2024

Inspired by #277 (that was most likely abandoned)

And ensure it support custom symbol

Testing done

Interactive tests with freestyle job with both image from report and symbol

With symbol

Screenshot from 2024-11-30 15-18-05
Screenshot from 2024-11-30 15-18-21

With image from report

Screenshot from 2024-11-30 15-31-16
Screenshot from 2024-11-30 15-23-56

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner November 30, 2024 14:32
@jonesbusy
Copy link
Author

Hi @jenkinsci/htmlpublisher-plugin-developers what do you think of this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant