Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jenkins-support #1835

Closed
wants to merge 1 commit into from
Closed

Conversation

Shubhdeep02
Copy link

#1456 fixing update plugins in docker jenkins

Testing done

Submitter checklist

Preview Give feedback

jenkinsci#1456 fixing update plugins in docker jenkins
@Shubhdeep02 Shubhdeep02 requested a review from a team as a code owner March 5, 2024 17:22
@MarkEWaite
Copy link
Contributor

@Shubhdeep02 this does not address the problem mentioned in the pull request description ( #1456 ) . It does not include a description of the testing that was done to assure that it runs correctly. It makes breaking changes to the existing script and fails the tests because of the breaking changes.

Do you plan to resolve those problems in this pull request or should the pull request be closed?

@Shubhdeep02
Copy link
Author

Thanks for the guidance @MarkEWaite please consider closing the PR ,i will take a look into it later.

@dduportal dduportal closed this Mar 6, 2024
@Shubhdeep02 Shubhdeep02 deleted the patch-1 branch March 7, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants