-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add importing of netmodule #819
base: master
Are you sure you want to change the base?
Conversation
Hi @kant2002! Thank you for your PR! Is this an actual case you're hitting? While the code seems to make sense, could you add tests for it? Thanks! |
@jbevain I was hitting that in the actual snippet which I wrote in the issue. That snipped was created by @ForNeVeR when he play with C compiler in .NET. He probably can explain more. Regarding tests, what's proper place to add test for this case? I was looking for them, but I cannot find nice place where I can validate case. |
Hey! The place to add a test would be there: https://github.com/jbevain/cecil/blob/master/Test/Mono.Cecil.Tests/ImportCecilTests.cs Thanks! |
This was an experiment while I was investigating how to create/use a Initially, I wanted to mimic the full C-style compilation: creating a separate Though right now I've deserted this approach (not because of any Cecil problems, but because I don't think it's appropriate). So, there are no any actual uses of It not impossible I'll decide to play with them again later, but not too likely, either. |
@jbevain I think this is ready for another round of review. |
@jbevain New year is soon. I behave well, so may I have some present on New Year, or on Christmas ? |
Closes #818