Edit old migrations to use new USER_MODEL setting value #572
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezheidtmann
force-pushed
the
use-user-model-in-migrations
branch
from
e1db3bb to
eed5267
Compare
|
Rebased on the latest release |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
USER_MODELsetting appears very useful, but in the 2.0.0 release, the original tables are created withuseras a ForeignKey tosettings.AUTH_USER_MODEL.This creates several problems, including that
./manage.py makemigrationswill create a migration inpush_notificationsthat can't be committed or deployed if the project was installed from pypi.This PR edits old migrations to use
USER_MODELdirectly. For new users, this seems to honor the intention of the feature. For existing users, they should expect trouble if they ever change theUSER_MODELorAUTH_USER_MODELsettings, with or without this patch.