Improve django-rest-framework support #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for authentication and not pass the credentials in the request body | ||
| """ | ||
| if isinstance(request, Request): | ||
| return request.data.items() |
There was a problem hiding this comment.
This would fail once you will start using any permission classes like TokenReadWriteScope and so on. Problem is that this perm classes will access this method and will fail if request.data is not a dictionary :) imagine request with json list payload.
p.s. DRF 2.x should be supported, where .data is not available.
|
I'm going to have to close this PR, the library changed quite a lot and so did DRF support. If you want to PR any improvements that you deem are still necessary, please do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I stubbled across some difficulties with DRF, and since you have an integration guide with it I think it could be helpful to bring some updates.
With multipart form requests I had an odd issue, because the request body was read by DOT before letting the form parser read it. It has been reported in #296, but no pull request associated, so here it is.
And I've added a little addition to the
OAuth2Authenticationclass to reject non active users (thanks to @pySilver for the heads-up).Cheers 🍻