Fixed Handled error in OAuth2ExtraTokenMiddleware when authheader has Bearer with no token-string following up
#1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n2ygk
force-pushed
the
bug/1496/unhandled-empty-bearer-token-exception
branch
from
3efa9a5 to
f87c5f4
Compare
n2ygk
requested changes
Sep 22, 2024
oauth2_provider/middleware.py
Outdated
Comment on lines
55
to
56
| if authheader.startswith("Bearer") and len(authheader.split(maxsplit=1)) == 2: | ||
| tokenstring = authheader.split(maxsplit=1)[1] |
There was a problem hiding this comment.
I suggest not calling split() twice:
Suggested change
| if authheader.startswith("Bearer") and len(authheader.split(maxsplit=1)) == 2: | |
| tokenstring = authheader.split(maxsplit=1)[1] | |
| splits = autheader.split(maxsplit=1) | |
| if authheader.startswith("Bearer") and len(splits) == 2: | |
| tokenstring = splits[1] |
There was a problem hiding this comment.
Thank you for your suggestion, I will make the changes by today!
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.5 → v0.6.7](astral-sh/ruff-pre-commit@v0.6.5...v0.6.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.7 → v0.6.8](astral-sh/ruff-pre-commit@v0.6.7...v0.6.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ps://github.com/Tuhin-thinks/django-oauth-toolkit into bug/1496/unhandled-empty-bearer-token-exception
|
@Tuhin-thinks this looks good. I think the last task to get this merge ready is the test. |
|
@dopry Thanks, I am getting them ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the crash in application while using OAuth2ExtraTokenMiddleware. When Bearer token passed is empty.
Authorization: Bearerwould result in this crash.Fixes #1496
Description of the Change
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS