Fix test for changed error message from newer Django (djmain) #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopry
reviewed
Sep 5, 2024
tests/test_commands.py
Outdated
| self.assertIn("user", output_str) | ||
| self.assertIn("783", output_str) | ||
| # newer Django (>5.1) changes the error message from "does not exist" to "is not a valid choice" | ||
| self.assertTrue( |
There was a problem hiding this comment.
would something like the following be more self documenting?
import django
if django.VERSION <= (5,1):
self.assertIn("does not exist", output.getvalue())
else:
self.assertIn("is not a valid choice", output.getvalue())There was a problem hiding this comment.
I had to make it a test for < (5,2) because (5,1) is not <= (5, 1, 1, 'final', 0) . I suppose the alternative would be to take the first 2 elements of the tuple, but I think this is readable enough....
n2ygk
force-pushed
the
bug/1482/assertion
branch
from
8aef61f to
6bf75c0
Compare
dopry
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1482
Description of the Change
Older Django has one error message that the failure test was looking for. Newer Django (main branch) has a different error message, so check for both.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS