lz4cli: consolidate xxhash to third_party version #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the internal xxhash within lz4cli and consolidate to the one true xxhash within third_party.
fzakaria
commented
Jul 8, 2023
| @@ -42,7 +41,8 @@ THIRD_PARTY_LZ4CLI_DIRECTDEPS = \ | |||
| LIBC_INTRIN \ | |||
| LIBC_STDIO \ | |||
| LIBC_LOG \ | |||
| LIBC_TIME | |||
| LIBC_TIME \ | |||
| THIRD_PARTY_XXHASH | |||
There was a problem hiding this comment.
Doesn't seem to be picking it up through
o/third_party/gcc/bin/x86_64-linux-musl-ld.bfd: o//third_party/lz4cli/bench.o: in function `BMK_benchMem':
third_party/lz4cli/bench.c:228: undefined reference to `XXH64'
o/third_party/gcc/bin/x86_64-linux-musl-ld.bfd: third_party/lz4cli/bench.c:333: undefined reference to `XXH64'
There was a problem hiding this comment.
You probably need to fix the include foo.mk lines in Makefile so they're topologically ordered again. xxhash.mk should come before lz4cli.mk.
jart
force-pushed
the
master
branch
2 times, most recently
from
faa6285 to
2c4b887
Compare
jart
force-pushed
the
master
branch
2 times, most recently
from
3048620 to
6245732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the internal xxhash within lz4cli and consolidate to the one true xxhash within third_party.