Document maintainer actions #6386
Open
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <[email protected]>
dosubot
bot
added
documentation
governance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6386 +/- ##
=======================================
Coverage 96.19% 96.20%
=======================================
Files 361 361
Lines 20604 20602 -2
=======================================
Hits 19821 19821
+ Misses 599 597 -2
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 18, 2024
MAINTAINERS.md
Outdated
| @@ -22,3 +22,73 @@ We are grateful to our former maintainers for their contributions to the Jaeger | |||
| * [@objectiser](https://github.com/objectiser) | |||
| * [@tiffon](https://github.com/tiffon) | |||
| * [@vprithvi](https://github.com/vprithvi) | |||
|
|
|||
| ### Criteria for Maintainership | |||
There was a problem hiding this comment.
are you repeating these from the Governance doc?
There was a problem hiding this comment.
i.e. we already have the process pretty well documented, the only part that was missing was the onboarding
There was a problem hiding this comment.
Sorry please re-review the last push!
Signed-off-by: Jonah Kowall <[email protected]>
yurishkuro
reviewed
Dec 18, 2024
yurishkuro
reviewed
Dec 18, 2024
Signed-off-by: Jonah Kowall <[email protected]>
jkowall
added
the
changelog:skip
Signed-off-by: Jonah Kowall <[email protected]>
yurishkuro
reviewed
Dec 18, 2024
yurishkuro
reviewed
Dec 18, 2024
| * `slack_notifications`: Slack ID for notifications (optional) | ||
| * `email`: Email address | ||
| * `modtime`: Timestamp (will be automatically updated) | ||
| * Reference the PR in the `cncf-jaeger-maintainers` mailing list. |
There was a problem hiding this comment.
what do you mean by that and why is it needed?
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #6370
Description of the changes
Adding a section in the document on onboarding, offboarding and other activities.
Checklist