Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api_v3] Add time window for GetTrace http_gateway #6372

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

rim99
Copy link
Contributor

@rim99 rim99 commented Dec 16, 2024

Which problem is this PR solving?

Description of the changes

  • Add optional time window for GetTrace http_gateway

How was this change tested?

  • unit test

Checklist

@rim99 rim99 requested a review from a team as a code owner December 16, 2024 23:26
@rim99 rim99 requested a review from pavolloffay December 16, 2024 23:26
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (d8984bb) to head (559f2fa).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6372   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         360      360           
  Lines       20484    20499   +15     
=======================================
+ Hits        19698    19713   +15     
  Misses        601      601           
  Partials      185      185           
Flag Coverage Δ
badger_v1 8.96% <ø> (ø)
badger_v2 1.63% <ø> (ø)
cassandra-4.x-v1-manual 14.93% <ø> (ø)
cassandra-4.x-v2-auto 1.57% <ø> (ø)
cassandra-4.x-v2-manual 1.57% <ø> (ø)
cassandra-5.x-v1-manual 14.93% <ø> (ø)
cassandra-5.x-v2-auto 1.57% <ø> (ø)
cassandra-5.x-v2-manual 1.57% <ø> (ø)
elasticsearch-6.x-v1 18.62% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.70% <ø> (ø)
elasticsearch-8.x-v1 18.86% <ø> (ø)
elasticsearch-8.x-v2 1.62% <ø> (-0.01%) ⬇️
grpc_v1 10.60% <ø> (-0.01%) ⬇️
grpc_v2 7.95% <ø> (ø)
kafka-v1 9.29% <ø> (ø)
kafka-v2 1.63% <ø> (ø)
memory_v2 1.62% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.75% <ø> (ø)
opensearch-2.x-v1 18.75% <ø> (ø)
opensearch-2.x-v2 1.63% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.45% <ø> (ø)
unittests 95.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zhang Xin <[email protected]>
@yurishkuro yurishkuro changed the title [V3][API] Add time window for GetTrace http_gateway [api_v3] Add time window for GetTrace http_gateway Dec 18, 2024
@yurishkuro yurishkuro merged commit dd799a0 into jaegertracing:main Dec 18, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants