[v2][adjuster] Rework adjuster interface and refactor adjusters to return implemented struct #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6362 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 360 360
Lines 20479 20485 +6
=======================================
+ Hits 19689 19695 +6
Misses 603 603
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 15, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Dec 15, 2024
internal/jotlp/package_test.go
Outdated
| // Copyright (c) 2024 The Jaeger Authors. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package jotlp |
There was a problem hiding this comment.
on reflection, I think we should name this package jpdata, since that's the name of the data model we use
There was a problem hiding this comment.
@yurishkuro since we're usually operating on ptrace.Traces - should we call it jptrace?
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Dec 16, 2024
| @@ -101,13 +102,13 @@ func TestResourceAttributesAdjuster_SpanWithConflictingLibraryAttributes(t *test | |||
| require.True(t, ok) | |||
| require.Equal(t, "Java", val.Str()) | |||
|
|
|||
| val, ok = resultSpanAttributes.Get("jaeger.adjuster.warning") | |||
| val, ok = resultSpanAttributes.Get(jptrace.WarningsAttribute) | |||
There was a problem hiding this comment.
nit: we should have GetWarnings() method instead (and the actual tag name could be private to the package)
There was a problem hiding this comment.
@yurishkuro implemented - can you take a look?
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Funcaliascmd/query/app/internal/jotlpHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test