-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help upgrading bulma #730
Comments
Hello, I'm new to the jaeger project but I'd like to start contributing. I would like to look at this-- I've started by looking over changes that occurred in the bulma project between versions 0.7.1 and 1.0.0. |
@vsoroten we welcome contributions. As a suggestion, going through all changes across versions of these modules might be a lot of work, it may be easier to start with the actual error message and investigate what's causing it. |
@yurishkuro I was able to reproduce the error. I was also able to update up to bulma v0.9.4 without error. The jump from bulma v0.9.4 to bulma v1.0.0 seems to be a common issue jgthms/bulma#3867. Looking into upgrading into bulma v1.0.0 now. |
Hey @yurishkuro an update --- I have gotten the project to build under bulma v1.0.0 and it seems like the initial issue was because bulma v1.0.0 now uses DartSass instead of sass. The issue I'm seeing now, is that the projects builds but no css is being applied. So far I've tried using the sass-migrator tool for sass modules under themes/jaeger-docs to perform the conversion to DartSass with no success. So I took a step back and dove deeper into the migration guide for bulma which didn't offer too many hints. |
I don't have any concrete suggestions, this isn't my area of expertise. Is it possible that Hugo directly supports sass without using Node modules? This build process was implemented quite a while ago. |
Hey @yurishkuro, not sure what else to explore with tackling the issue.
which converted the Sass to DartSass automatically for all .sass files in this directory. However, when rendering the website, it seems that CSS still isn't applied.
It is possible for Hugo to directly support sass. But are you suggesting that we remove the dependency on Bulma in package.json and just install it via
instead? I also see that the project did not originally include Bulma in Node modules this issue #139 gave me more context for why this was chosen. For now I'm not sure how to grok the issue further since it seems like when there aren't any errors, there is a silent failure (like with the CSS not being rendered). |
Looking at the links you provided, dart sass option in Hugo is just another transpiler, I don't really see much difference on how it makes the integration easier. So I think it would make more sense to stick with bulma and figure out why it doesn't work. |
Use dartsass transpiler because bulma no longer supports the hugo default libsass. Remove semicolon at end of indented lines because of build errors. Signed-off-by: Miroljub Enjakovic <[email protected]>
So, I've taken a look at the issue and here are my finding @yurishkuro, which align with what @vsoroten said. I've added a PR #733 with non visual changed. I'm not exactly an expert on visuals, so if someone else can update them it would be great, otherwise I may work on it, but it may take a while. |
The bot is trying to upgrade bulma modules in the SASS setup:
If after the above change I go to
cd themes/jaeger-docs/
and runnpm install
to update the vendored dependencies, then the build later fails with SASS errors:The text was updated successfully, but these errors were encountered: