Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to docsy theme #746

Open
yurishkuro opened this issue Sep 19, 2024 · 10 comments
Open

Migration to docsy theme #746

yurishkuro opened this issue Sep 19, 2024 · 10 comments

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Sep 19, 2024

Jaeger website today is using a completely custom theme. This creates a maintenance headache as we run into various layout bugs (e.g. #744, #745). We also have issues with some old dependencies for CASS like bulma (#730).

I looked around in other CNCF projects and noticed that both OpenTelemetry and Kubernetes websites are using https://github.com/google/docsy theme, which is likely much better supported.

Of course, it's not a very trivial job to replace the theme, as we also have plenty of CSS customizations that we would want to keep. So before we really decide to do that we need some investigation, e.g. just trying out enabling the docsy theme and spot-checking what would break in Jaeger as a result, and collect the findings into a report.

One thing we'd need to do is customize the color schemes to match the existing Jaeger website (https://www.docsy.dev/docs/adding-content/lookandfeel/)

@Dindihub
Copy link

Hi, @yurishkuro Did you get help with this issue? I worked on a similar project for theupdateframework during my LFX mentorship program Term 2 2024. I would be glad to assist.

@yurishkuro
Copy link
Member Author

@Dindihub We do need help.

@chalin
Copy link

chalin commented Nov 19, 2024

/cc @nate-double-u, since we talked about this during our techdocs call this morning. @yurishkuro - we were curious if you had create a ticket for this?

Btw, @Dindihub contributed to the bulk of the base work of the following:

I'm about to wrap up the Docsy migration for the in-toto project. I plan to look into what would be involved for this project. Maybe @Dindihub will look into it before then too.

@yurishkuro
Copy link
Member Author

we were curious if you had create a ticket for this?

@chalin sorry, I didn't follow - are you asking about the JIRA ticket I opened long time ago? That one was more about informational structure review / recommendations (especially since we just rolled out new documentation for Jaeger v2).

@chalin
Copy link

chalin commented Nov 19, 2024

Thanks for the context. I was wondering if you had opened a new ticket that I might not have been aware of (not an obligation of course).

yurishkuro added a commit that referenced this issue Nov 19, 2024
## Which problem is this PR solving?
- Part of #746

## Description of the changes
- Move Jaeger-specific short codes and partials that are more related to
content than the styling into a `basetheme` so that they can continue
working when we switch the theme to docsy

## How was this change tested?
- Spot-check local build

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
Copy link
Member Author

@chalin fwiw upgrading to docsy would be much higher priority

@Dindihub
Copy link

/cc @nate-double-u, since we talked about this during our techdocs call this morning. @yurishkuro - we were curious if you had create a ticket for this?

Btw, @Dindihub contributed to the bulk of the base work of the following:

I'm about to wrap up the Docsy migration for the in-toto project. I plan to look into what would be involved for this project. Maybe @Dindihub will look into it before then too.

Noted. Thanks @chalin

@chalin
Copy link

chalin commented Dec 10, 2024

@yurishkuro - we're discussing this as possibly in scope for 2025. Btw, I'd remove the good first issue label since this work requires a lot of expertise, and is an undertaking that will span weeks.

@yurishkuro
Copy link
Member Author

@chalin removed good first issue. When do you expect to come to a decision and have clarity on the timeframes?

@chalin
Copy link

chalin commented Dec 10, 2024

@yurishkuro - before year's end. Either @nate-double-u or I will reach out (possibly via Slack and or the Jira ticket open for this repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants