Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test ci for mysql service #440

Closed
wants to merge 18 commits into from
Closed

chore: test ci for mysql service #440

wants to merge 18 commits into from

Conversation

Chris53897
Copy link

No description provided.

@@ -69,6 +66,9 @@ jobs:
--health-cmd "pg_isready" --health-interval 10s --health-timeout 5s --health-retries 5

steps:
- name: start
run: docker run -d mysql:8.3 --character-set-server=utf8mb4 --collation-server=utf8mb4_unicode_ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i understand correctly, this starts another mysql instance but we keep using the one from services.

@dbu
Copy link
Member

dbu commented Feb 16, 2024

i decided in #439 to require the encoding to be set, either with the charset param to dbal, the defaultTableOptions.collate or by calling Client::setCaseSensitiveEncoding()

thanks again for the help on this one.

@dbu dbu closed this Feb 16, 2024
@Chris53897
Copy link
Author

i did not actualy help much. It was just a quick try.
Thank you for working on the dbal 4 support

@Chris53897 Chris53897 deleted the feature/dbal-4 branch February 16, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants