Fix : parameter order in connect method and allow dynamic host connection #68
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions - Corrected the parameter order in the connect method of both OpcDaClient and OpcCom classes to ensure the correct sequence of opc_server and opc_host. - Updated the connect method to allow dynamic host connections instead of defaulting to 'localhost', providing more flexibility in server connections. - Improved type annotations for better code clarity and type safety. Changes: - Swapped the order of parameters in the connect method to server, host for consistency and correctness. - Removed the hardcoded 'localhost' assignment, allowing the host to be specified dynamically. - Enhanced type annotations for opc_server and opc_host parameters. Impact: - These changes ensure that the OPC client can connect to specified servers and hosts correctly, enhancing the flexibility and usability of the library.
renzop
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67
If this behavior was implemented intentionally to enforce a 'localhost' connection, feel free to close this request!
Changes:
Impact: