Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a numeric field for version info. #39

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Dec 10, 2024

No description provided.

@Carreau Carreau force-pushed the version_info branch 2 times, most recently from 5468b6c to 7313f1f Compare December 10, 2024 10:55
And setup auto publication
@ianthomas23
Copy link
Collaborator

It looks like I need to improve the workflow of the visual tests I added. I suspect that if the comparison images have changed CI is hanging trying to display the differences.

@Carreau
Copy link
Member Author

Carreau commented Dec 10, 2024

Yeah, that is what I figured, and why I regenerated the notebooks.
I guess we can use admin permission to merge; and figure that out later.

@ianthomas23
Copy link
Collaborator

I've looked through the nbdime docs and I can't see a way of using it for the image comparisons without it also trying to display the differences in a browser. Maybe we should just disable these tests for now and I will come up with an alternative which is either based on how Matplotlib or Jupyter do such tests rather than this third way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants