move ipyparallel-specific code to this package #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subclass that defines apply_request handler
import from ipyparallel instead.
minrk
force-pushed
the
parallel-to-ipyparallel
branch
from
b4a831d to
3602cb6
Compare
minrk
added a commit
that referenced
this pull request
Nov 3, 2015
move ipyparallel-specific code to this package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copied out of ipykernel. I will open PR against that repo that deprecates these APIs in ipykernel. These are mostly the Python object serialization used by
data_pubandapply_request, which do not make sense outside ipyparallel.ipyparallel.serializeIPythonParallelKernelis a subclass that definesapply_requestand some modifications toexecute_requestthat should become unnecessary after pushing some changes upstream to the base class.ZMQDataPublisherandEnginePUBHandlerare moved to this repo as well.Related: ipython/ipykernel#17