Update FSAC to use FCS and FSharp.Core from 9.0.100, as well as updated Analyzer SDK #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
changed the title
…conditionally-compile away ta call with a new API in .NET 9
TheAngryByrd
commented
Nov 19, 2024
| @@ -413,7 +413,12 @@ and AdaptiveCancellableTask<'a>(cancel: unit -> unit, real: Task<'a>) = | |||
| real | |||
| else | |||
| cachedTcs <- new TaskCompletionSource<'a>() | |||
| #if NET8_0 | |||
| cachedTcs.TrySetFromTask real | |||
| #if NET9_0_OR_GREATER | |||
| cachedTcs.TrySetFromTask real |> ignore<bool> | |||
There was a problem hiding this comment.
I think we have to call this from within the current TrySetFromTask as it needs to be a completed task.
TheAngryByrd
force-pushed
the
dotnet9
branch
3 times, most recently
from
df9652f to
becea2a
Compare
TheAngryByrd
force-pushed
the
dotnet9
branch
from
becea2a to
9791109
Compare
baronfel
reviewed
Nov 24, 2024
| real.ContinueWith(fun (task: Task<_>) -> | ||
| real.ContinueWith (fun (task: Task<_>) -> | ||
| #if NET9_0_OR_GREATER | ||
| tcs.TrySetFromTask(task) |> ignore<bool> |
There was a problem hiding this comment.
oh fascinating - so the runtime is generally getting APIs that are better/correct/easier to use?
baronfel
reviewed
Nov 24, 2024
| @@ -111,7 +111,8 @@ let private getRangesAndPlacement input pos = | |||
| members | |||
| |> List.tryPick (fun m -> | |||
| match m with | |||
| | SynMemberDefn.AutoProperty(accessibility = None; ident = ident; trivia = trivia) as a when | |||
| // TODO: Need to handle setting get or set accessibility separately | |||
There was a problem hiding this comment.
Making a comment here to make a link to this todo for an issue - we need to be able to handle the other AST cases when the getter or setter have different visibilities.
baronfel
reviewed
Nov 24, 2024
| @@ -303,8 +303,8 @@ let formattingTests state = | |||
| | Result.Error e -> failwithf "Error while formatting %s: %A" sourceFile e | |||
| | Core.Result.Error errors -> failwithf "Errors while parsing script %s: %A" sourceFile errors | |||
| }) | |||
|
|
|||
| testList | |||
| // Skip until https://github.com/dotnet/sdk/issues/44838 is fixed | |||
There was a problem hiding this comment.
This should be the first week of December FWIW
baronfel
approved these changes
Nov 24, 2024
TheAngryByrd
added a commit
to TheAngryByrd/FsAutoComplete
that referenced
this pull request
Dec 7, 2024
…ed Analyzer SDK (ionide#1324) Co-authored-by: Chet Husk <[email protected]>
TheAngryByrd
added a commit
to TheAngryByrd/FsAutoComplete
that referenced
this pull request
Dec 8, 2024
…ed Analyzer SDK (ionide#1324) Co-authored-by: Chet Husk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1323