Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header: updated quick actions dropdown. #2526

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alejandromumo
Copy link
Member

@alejandromumo
Copy link
Member Author

Result:

Unauthenticated users

Screenshot at Nov 01 14-06-59

If the user clicks "New upload" or "New community", they're redirected to the login page

Authenticated users

Screenshot at Nov 01 14-06-49

@lnielsen
Copy link
Member

lnielsen commented Nov 2, 2023

Can you keep the original menu item text:

  • New upload
  • New community

Also the caret down icon is missing after the ...

@alejandromumo alejandromumo force-pushed the rename_quick_dropdown_options branch from 6ba9418 to 03d61ae Compare November 2, 2023 09:05
@alejandromumo
Copy link
Member Author

Can you keep the original menu item text:

* New upload

* New community

Also the caret down icon is missing after the ...

Screenshot at Nov 02 10-04-29

@kpsherva
Copy link
Contributor

kpsherva commented Nov 2, 2023

small suggestion: could you increase a distance between + and New ? it seems a little bit too cramped together

@alejandromumo
Copy link
Member Author

small suggestion: could you increase a distance between + and New ? it seems a little bit too cramped together

I am not sure if what I did is correct in terms of good practices (let me know if it isn't): I added an ID to the label and added a margin-left.

Screenshot at Nov 06 09-41-55

@ntarocco
Copy link
Contributor

ntarocco commented Nov 6, 2023

I am sure you checked, but just to be sure, does the link correctly redirect to login when anonymous?

@jbenito3
Copy link
Member

jbenito3 commented Nov 6, 2023

small suggestion: could you increase a distance between + and New ? it seems a little bit too cramped together

I am not sure if what I did is correct in terms of good practices (let me know if it isn't): I added an ID to the label and added a margin-left.

Screenshot at Nov 06 09-41-55

it seems to me like now there is a huge space on the left...

@kpsherva
Copy link
Contributor

kpsherva commented Nov 7, 2023

after some discussions, we decide it to postpone it until optimal solution is found

Copy link
Contributor

github-actions bot commented Jan 7, 2024

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity for more than 60 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants