Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add unsafe_convert to pointer #102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

oxinabox
Copy link
Member

This is part of trying to get this wo work with distributions

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #102 into master will increase coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   89.18%   89.29%   +0.10%     
==========================================
  Files           9        9              
  Lines         296      355      +59     
==========================================
+ Hits          264      317      +53     
- Misses         32       38       +6     
Impacted Files Coverage Δ
src/wrapper_array.jl 89.23% <66.66%> (-5.22%) ⬇️
src/functions_dims.jl 100.00% <0.00%> (ø)
src/name_operations.jl 88.88% <0.00%> (ø)
src/name_core.jl 92.98% <0.00%> (+1.31%) ⬆️
src/broadcasting.jl 57.57% <0.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd00f0...376ff44. Read the comment docs.

Co-Authored-By: Michael Abbott <[email protected]>
@mcabbott
Copy link
Collaborator

mcabbott commented Jun 7, 2020

Bump?

@oxinabox
Copy link
Member Author

oxinabox commented Jun 7, 2020

I never ended up needing this, so never wrote tests so can't merge it

@mcabbott
Copy link
Collaborator

mcabbott commented Jun 7, 2020

Perhaps just this?

nda = NamedDimsArray(rand(2,2), (:x, :y))
@test pointer(nda) == pointer(parent(nda))

This passes without the method I suggested, i.e. with only Base.unsafe_convert defn, so perhaps that's enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants