Searching through Vector{IndexEntry}
#46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion for selection entries by fullname or deprecated name.
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 96.20% 95.28% -0.92%
==========================================
Files 5 5
Lines 158 191 +33
==========================================
+ Hits 152 182 +30
- Misses 6 9 +3
|
morris25
reviewed
Jul 21, 2022
| TestPkg.qux(a, b) | ||
|
|
||
| index = index_checkpoint_files(path) | ||
| entry= only(index) |
There was a problem hiding this comment.
Suggested change
| entry= only(index) | |
| entry = only(index) |
|
|
||
|
|
||
| # Utility function for generating a checkpoint name lookup table from the current registry | ||
| function _depnames_lookup() |
There was a problem hiding this comment.
The amount of added complexity here makes me wonder if we're accounting for deprecations in the correct way. I'm not sure we should allow a deprecation to point to another deprecation.
| end | ||
|
|
||
| function IndexEntry(filepath::AbstractPath, base_dir) | ||
| function IndexEntry(filepath::AbstractPath, base_dir, depnames_lookup=_depnames_lookup()) |
There was a problem hiding this comment.
Is there a reason we're passing this in rather than calling it in the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #45, we may want to support storing deprecated checkpoint information in the index and add some minimal search functionality to make working with collections of
IndexEntrytypes easier.