Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Windows use Triton cache dir per pytest worker #3041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

On Windows use Triton cache dir per pytest worker #3041

wants to merge 1 commit into from
+7 −0

Conversation

pbchekin
Copy link
Contributor

Fixes #2777.

pbchekin
pbchekin commented Dec 18, 2024
View reviewed changes
python/test/unit/conftest.py
worker_id = os.getenv("PYTEST_XDIST_WORKER")
# On Windows, use a dedicated Triton cache per pytest worker to avoid PermissionError.
if os.name == "nt" and worker_id:
os.environ["TRITON_CACHE_DIR"] = tempfile.mkdtemp(prefix="triton-")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use worker_id as a unique identifier in the name of cache directory.

I could, but worker_id won't help to debug potentials issues, since we still need to know unique/random suffix.

@pbchekin pbchekin mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshimansky gshimansky Awaiting requested review from gshimansky

@anmyachev anmyachev Awaiting requested review from anmyachev

@whitneywhtsang whitneywhtsang Awaiting requested review from whitneywhtsang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WIN] Parallel tests execution fails because of locked files
1 participant
@pbchekin