Port and run tests in python/test/unit/tools #2953
Conversation
Compile support Link support gen bin success, but x1 hangs todo:segfault fix fix Enable Clean
ESI-SYD
requested review from
pbchekin,
whitneywhtsang,
etiotto and
chengjunlu
python/test/unit/tools/test_aot.py
Outdated
| cwd=dir, | ||
| ) | ||
| o_files = glob.glob(os.path.join(dir, "*.o")) | ||
| if is_cuda(): |
There was a problem hiding this comment.
May be to minimize changes and simplify future potential merges
| if is_cuda(): | |
| if is_xpu(): | |
| gen_kernel_library_xpu(dir, libname) |
and keep the rest of the function as the original?
There was a problem hiding this comment.
Thanks for review. Changed in f6aaed5
| @@ -132,27 +134,46 @@ def gen_signature(m): | |||
|
|
|||
| # generate declarations of kernels with meta-parameter and constant values | |||
| def make_algo_decls(name: str, metas: Sequence[KernelLinkerMeta]) -> str: | |||
| return f""" | |||
| if is_cuda(): | |||
There was a problem hiding this comment.
Can we remove the check is_cuda() ?
There was a problem hiding this comment.
No, return wrong source string for xpu if removed.
|
|
||
|
|
||
| # generate declarations of kernels with meta-parameter and constant values | ||
| def make_global_decl(meta: KernelLinkerMeta) -> str: | ||
| return f""" | ||
| if is_cuda(): |
There was a problem hiding this comment.
Can we remove the check is_cuda() ?
|
@whitneywhtsang are you OK with these changes? |
Done |
Thanks, maybe cleaner to put them in a folder, like |
There was a problem hiding this comment.
Can this change be upstreamed?
There was a problem hiding this comment.
I think we can try. The change puts the backend templates in the corresponding location instead of the public folder, looks reasonable.
There was a problem hiding this comment.
I agree, please give that a try.
There was a problem hiding this comment.
All cases pass except for
tools/test_aot.py::test_compile_link_matmul_no_specialization SKIPPED (FIXME: AssertionError on XPU-> #2967